Skip to content
Submitted about 2 years ago

QR Code Component Solution

Ammar Khalid•20
@ammar886
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

How do you guys find my code? Is it clean? what can be improved?

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @ammar886, Congratulations on completing this challenge!

    Your component is okay but it's missing the vertical alignment. The best way to do it is by using flexbox. First step is to add min-height: 100vh to make the body height size becomes 100% of the screen height, this way you make sure that whatever the situation the child element (the container) align the body and then use the flex properties for alignment with display: flex / align-items: center; / justify-content: center;

    REMOVE THESE MARGINS:

    .container {
    width: 300px;
    height: 480px;
    background-color: white;
    border-radius: 5%;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    /* margin: auto; */
    /* margin-top: 55px; */
}

    ALIGN WITH MIN-HEIGHT AND FLEXBOX:

    body {
    min-height: 100vh;
    background-color: hsl(212, 45%, 89%);
    display: flex;
    align-items: center;
    justify-content: center;
}

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Ammar Khalid•20
    @ammar886Posted about 2 years ago

    @correlucas Thanks for the detailed guideline. I'll surely keep this in mind. Another thing? Do I need to use the body as flex-container? In this solution, I had used the white background rectangle as my container.

    0
  • Adriano•38,330
    @AdrianoEscarabotePosted about 2 years ago

    Hi Ammar Khalid, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Document should have one main landmark, you could have put all the content inside the main tag click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    Ammar Khalid•20
    @ammar886Posted about 2 years ago

    @AdrianoEscarabote Thanks for such a detailed guideline. I'll surely look into it the next time.

    0
    Adriano•38,330
    @AdrianoEscarabotePosted about 2 years ago

    @ammar886 no problem, keep coding!

    0
  • Vincent Daniel•410
    @davinceeyPosted about 2 years ago

    Hello Ammar Khalid. Congratulations on finishing this project! And, yes, your solution is clean😁. Just some little tips for improvement:

    1. You could do well to wrap all your content in a <main> tag. You made use of a lot of divs. You could just make use of a <section> tag to group your work just right under the svg.

    2. I observed that your writeups were not wrapped in any tags. It would be good HTMML practice to wrap your codes in tags. Your should use this instead <h1>Improve your front-end <br> skills by building projects</h1> and a p tag for the second write-up.

    3. You could also make use of relative units like the em and rem for padding, margins, and widths. This would enable your site to be more responsive.

    Hope this helps you. Happy Coding!👊

    Marked as helpful
    0
    Ammar Khalid•20
    @ammar886Posted about 2 years ago

    @davinceey I actually do struggle with relative units but I'll take a look at them again. Thanks Vincent!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord