Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Code Component Solution

MrByford 80

@MrByford

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Mennatallah-Hisham

Posted

Hi MrByford,

Congratulations on completing your first challenge👏

You did great 👍

Here are some suggestions to improve your code:

Semantic HTML

  • you did great in using semantic html but i suggest you read more about the difference between <srticle> & <section>

ALT

  • images should have descriptive alt text, which is important for SEO and screen reader users,alt="QR code linking to Frontend Mentor challenges"

SEO

  • you can add meta description for better SEO, it provides a brief summary of a web page
<meta name="description" content="..........."/>  

here are some helpful articles:

Hope you find this helpful, Happy Coding

Marked as helpful

0

MrByford 80

@MrByford

Posted

@Mennatallah-Hisham Thank you for taking the time to view my project and provide some valuable feedback. I have now altered the code and used what I now believe to be the full and correct semantic html structure. Using <section> to denote the "section" on my website and <article> for the self contained content including the <h1> tag. I have also added some SEO optimisation along with the image alt tag. I overlooked the seo parts as this was just a challenge but I understand how it could seem completely missed. I will include these on all challenges to keep up best practice.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord