QR Code Component Solution // HTML & CSS

Community feedback

• 

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  Actually a good solution!! Congrats!

  A few things:

  • Why should you have a height from 100vh on the body?

  • Be sure that you be consistent with the use of rem for font-sizes

  • Consider the use of the newer margins/padding declaration. In this example the write direction is from left to right. Margin-inline-start (left) Margin-inline-end (right) Margin-block-start (top) Margin-block-end (bottom

  • use a css reset ( look on Andy's Bell his website for a clear and good one)

  I have written a solution with an explanation for beginners.

  I gave feedback to a few people and saw that they do the same things wrong, so I decide to write this solution.

  So you can read my solution with explanation here:

  https://www.frontendmentor.io/solutions/qrcode-solution-with-explanation-0LCmcOmbrj

  Marked as helpful

  1