QR code component solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS Reset 🔄:

  • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

    CSS resets that are widely used:

    • Reset CSS
    • "My Custom CSS Reset" by JoshWComeau

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  2

  ---

  

  aaish•310

  @aaishverPosted almost 2 years ago

  @MelvinAguilar hello buddy can you tell me where to find the images and background for product oder summary challenge

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="tata"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  Give . text a margin value for all the sides and font-size of 0.9375rem which is 15px, this will be the font-size for both h1 and p. Give p a margin-top value for the space between the text.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  1

  ---

  

  aaish•310

  @aaishverPosted almost 2 years ago

  @Hassiai thanks but now i have done all with this and i just use these div class just random

  0