Submitted 6 months ago

QR Code Component Solution

Mostafa•50

@MostafaSaad1987

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud of getting it actually done, as I have forgotten quite a lot about CSS, and how tedious it can sometimes be.

What challenges did you encounter, and how did you overcome them?

The little details. Stuff like the spacing between elements, which could be done in a much better way, I just don't remember how to do so.

What specific areas of your project would you like help with?

Better ways to align items. My solution feels like spaghetti code, so any constructive criticism would be nice. Oh, and the spacing too. I feel like both could have been done in much better ways.

Community feedback

Daniel 🛸•44,250
@danielmrz-devPosted 6 months ago
Hello there!

Congrats on completing the challenge! ✅

Your solution looks great!

I have a suggestion for improvement:

📌 Think about using <main> to wrap your main content instead of <div>.

Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

Hope that's helpful!

Keep up the great work!
Marked as helpful
2
Mostafa•50
@MostafaSaad1987Posted 6 months ago
@danielmrz-dev Thank you for the comment and the suggestion! I have updated the main content to be wrapped in <main> instead of <div>, and I will use the <main> tag for the main page content in my future projects.
1

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord