Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component solution

@Crea8Boss

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML πŸ“„:

  • Wrap the page's whole main content in the <main> tag.

CSS 🎨:

  • The simplest way to set the height of the body element is with min-height: 100vh, setting the height to 100% on both the body and html elements can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

    Here is an image of how it would look on a mobile device (taking into account the scroll): screenshot

  • Instead of using pixels in font-size in the * selector, use relative units like em or rem (15px = 0.938rem). Source πŸ“˜.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1

@Crea8Boss

Posted

@MelvinAguilar Very helpful feedback, thank you.

1
Hassia Issahβ€’ 50,650

@Hassiai

Posted

Replace <article class="content"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

To center .content on the page using grid, add min-height: 100vh to the body.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

@Crea8Boss

Posted

@Hassiai Very helpful feedback, thank you.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord