@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π:
- Wrap the page's whole main content in the
<main>
tag.
CSS π¨:
-
The simplest way to set the height of the body element is with
min-height: 100vh
, setting the height to 100% on both the body and html elements can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.Here is an image of how it would look on a mobile device (taking into account the scroll): screenshot
- Instead of using pixels in font-size in the * selector, use relative units like
em
orrem
(15px = 0.938rem). Source π.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@Crea8Boss
Posted
@MelvinAguilar Very helpful feedback, thank you.