QR code component solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • The simplest way to set the height of the body element is with min-height: 100vh, setting the height to 100% on both the body and html elements can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

    Here is an image of how it would look on a mobile device (taking into account the scroll): screenshot

  • Instead of using pixels in font-size in the * selector, use relative units like em or rem (15px = 0.938rem). Source 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Oluwole Kosile-Palmer•90

  @Crea8BossPosted almost 2 years ago

  @MelvinAguilar Very helpful feedback, thank you.

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <article class="content"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .content on the page using grid, add min-height: 100vh to the body.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Oluwole Kosile-Palmer•90

  @Crea8BossPosted almost 2 years ago

  @Hassiai Very helpful feedback, thank you.

  0