Skip to content
Submitted 5 months ago

QR code component

David Khuu•30
@davidkhuu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Picking up Sass as quickly as I did. CSS is pretty straightforward to write but Sass helps take the tediousness out of it.

Next time, maybe I'd try a different CSS pre-processor. I also relied heavily on the Figma file for exact measurements so next time maybe I'd try eyeballing it to challenge myself.

What challenges did you encounter, and how did you overcome them?

I forgot some basic CSS styles that I could usually fall back on in React. With raw HTML/CSS, I needed to search documentation online about the right properties I needed.

What specific areas of your project would you like help with?

Some Sass related questions:

  • Is Sass the biggest CSS pre-processor? How is its usage vs. Less in the real world?
  • Do *.css.map files need to be committed to git or could I have gitignored these file types?

Community feedback

  • Whythree•90
    @WhythreePosted 5 months ago

    Looks good. Cant give a definite answer but i decided against committing the .css.map file and saw no problems.

    I like your use of classes and variables. Makes your css reusable. You were very diligent even on a small project like this. This is something I can definitely take away from your project.

    Only thing i have noticed is your use of px units. Rem units are more accessible since they scale the conent based on users browser settings

    Good job overall

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord