Skip to content
Submitted about 2 years ago

QR Code Component Solution

Tyler Bryce Obier•40
@tylerbryceobier
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Nothing was to difficult about the project, very beginner friendly. I'm unsure of the accuracy of the border radius of the container and image.

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @tylerbryceobier 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

    With semantic tags:

    <body>
   <main class="wrapper">
      <article class="card">
         . . .
      </article>
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

    Solution:

    <h1>Improve your front-end skills by building projects</h1>

    The <p> element represents paragraph-level content, usually text:

    <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>

    • Centering the element with position would make your element behave strangely on some mobile devices. There are two modern CSS techniques to center elements instead of using the position property.

    • There are two modern CSS techniques to center elements:

    Using flexbox layout:

    body {
   width: 100%;
   min-height: 100vh;
   display: flex;
   flex-direction: column;
   justify-content: center;
   align-items: center;
}

    Using grid layout:

    body {
   width: 100%;
   min-height: 100vh;
   display: grid;
   place-content: center;
}

    Links with more information:

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    1
    Tyler Bryce Obier•40
    @tylerbryceobierPosted about 2 years ago

    @MelvinAguilar Wow thank you for the resources. Im pretty new im going to absolutely read into all of this tips and redo this. Once again i appreciate it so much

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord