Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
nothing
What challenges did you encounter, and how did you overcome them?nothing
What specific areas of your project would you like help with?idk
Community feedback
- @Islandstone89Posted 11 months ago
Hey there, great job! Only a few minor suggestions to improve it even further...
HTML:
-
The alt text also needs to say where it leads (frontendmentor.io).
-
.attribution
should be a<footer>
. -
Footer text needs to be wrapped in a
<p>
.
CSS:
-
It's good practice to include a CSS Reset at the top.
-
As fas as I can see, you don't need the
aspect-ratio
on the image. Also, adddisplay: block
and replacewidth
withmax-width: 100%
.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord