Skip to content
Submitted over 1 year ago

QR code component solution

Olena Shevchenko•200
@olenahelena
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted over 1 year ago

    Hi, congrats on completing the challenge. To avoid accessibility issues write code in main tag as:

    <body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
    • It is preffered to use rem unit for font-size and em unit for margin and width.

    Hope you will find this Feedback Helpful.

    Marked as helpful
    1
    Olena Shevchenko•200
    @olenahelenaPosted over 1 year ago

    @atif-dev thank you! yes, this is really helpful!

    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
    • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.
    • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    Olena Shevchenko•200
    @olenahelenaPosted over 1 year ago

    @0xAbdulKhalid thank you so much! I will use this advice in my next project.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord