QR code component - solution

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Vitor Shigueta•80

  @VitorShiguetaPosted over 1 year ago

  @0xAbdulKhalid Thanks for your feedback

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. Instead of using a <main> element for the attribution, it would be more appropriate to use a <footer> element. The reason for using a <footer> element is to semantically indicate that the content within it represents the footer section of the webpage.

  The footer section typically contains information about the author, credits, copyright notice, or links to related resources. In this case, the attribution information for the challenge and the coder would fit well within a footer element.

  Here's the updated code using a <footer> element:

  <footer>
  <div class="attribution">
  Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
  Coded by <a href="#">Vitor Shigueta</a>.
  </div>
  </footer>
  

  By using the <footer> element, you provide clearer semantics to both users and search engines, indicating that the content within it is part of the footer section of the webpage.

  Marked as helpful

  0

  ---

  

  Vitor Shigueta•80

  @VitorShiguetaPosted over 1 year ago

  @Kamlesh0007 Thanks for your feedback

  0