Skip to content
Submitted 8 months ago

QR code component solution

Aaqib•170
@aaqibqadeer
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

completed the challenge

What challenges did you encounter, and how did you overcome them?

design instruction didn't have width and height mentioned.

What specific areas of your project would you like help with?

I want to know if I have followed the best practices and design is matching the mockup

Community feedback

  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    Hi @aaqibqadeer ,

    Nice Work !

    I would suggest following:-

    1.Prefer replacing <div class="card"> with <main> element.

    2.Use <h1> element for following instead of <div>:-

    Now:-

    <div>Improve your front-end</div>
<div>skills by building projects</div>

    After Change:-

    <h1>Improve your front-end skills by building projects</h1>

    3.Use <p> element instead of <div class="card-subtitle">.

    These will enhance your code, improve accessibility and make your markup more semantic.

    Hope these suggestions are helpful !

    Happy Coding !

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord