@IamArshadAli
Posted
Hey there! Congratulations on completing your first challenge on Frontend Mentor! 🎉
It's a great achievement, and I'm glad to see your enthusiasm for learning and improving. 🎖️
After reviewing your code, here are a few areas where you can make some enhancements to further develop your skills: 🔍
- Organize Files: Consider putting your
HTML
,CSS
, and other relevant files into separate folders to improve the organization of your project.
| assets/
|- images/
|-- image-qr-code.png
|-- screenshot.png
|-css/
|-- style.css
| index.html
| README.md
- Separate CSS: Keeping your
CSS
file separate from theHTML
will make your code look cleaner and more maintainable.
...
<head>
<link rel="stylesheet" href="./assets/css/style.css">
...
</head>
...
- Use Relative Values: When sizing elements in
CSS
, consider using relative values likepercentages
,em
, orrem
to make your layout more flexible and adaptable to different screen sizes.
.card {
padding: 1rem 0.5rem;
}
- Keep Color Values in
:root
Storing color values in the:root
selector allows you to define reusable variables for colors throughout your code, making it easier to maintain consistency and make global changes to your color scheme.
:root {
--clr-red: hsl(0, 100%, 66%);
}
h2 {
color: var(--clr-red);
}
- Play with paragraph color and shadow to make your design look more identical to the challenge
.card {
box-shadow: .1rem 1rem 3rem lightblue;
}
These are just suggestions to help you improve your skills. 🚀
There is a lot more ahead. Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance. 🤝
Happy coding! 🤓
Marked as helpful