QR code component solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="card">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give the alt attribute in the img a value, its value is the description of the image. the closing tag of <h1> should be </h1> not </h2>.

  There is no need to give the position: absolute.

  To center .card on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .card on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .card on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Give .card a background-color of white, for a responsive content, give .card a fixed max-width value and a padding value for all the sides. max-width:320px padding:16px . Give the img a max-width of 100% and a border-radius value.

  This challenge does not require a box-shadow.

  Give .container a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top value for the space between the text.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  UbaidRussell•140

  @UbaidRussellPosted almost 2 years ago

  @Hassiai Thank you for the feedback It really helped me improve my design to be more appealing and meet the project requirements. 🙏🏾🤍

  1