QR code component solution

Community feedback

• 

  Sajana Wijesinghe•460

  @StormKing969Posted over 2 years ago

  Hi,

  I took some time to look at your solution and you did a great job!

  The only thing I would have done differently would be grabbing the p tag using p:first-of-type and p:last-of-type. Instead, I would have used a span tag and given them a class name (or given the p tag a class name)

  That way when I go back to my CSS file, I know the exact tag I targeting but that's just my personal preference

  Another thing is that I'll take a look at the Semantics in HTML when structuring your HTML content

  Have a nice day & Happy coding!

  0
• 

  jack fikolson aka frontfliper•145

  @areklazPosted over 2 years ago

  Cool, but a bit too wide :)

  0