JD• 20
@JhonD1
Posted
Great looking work! For accessibility, it's good to use semantic tags where possible.
1
Design comparison
Community feedback
Ammon Quarshie• 20
@niiquash
Posted
- I love how you used variables in your css. Overall this turned out really great.
- On the topic of semantic html, I think you used a lot more div elements than normal. To ensure a more sematic approach, try using a structure that kinda tells a story. For example, I had this structure within the body element: "<article>
And then from there you can add the classes you want and style them from there. Great job overall.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord