Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component solution

P
Adrian 170

@litewskidev

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="wrapper"> with the main tag and wrap Improve your front-end skills by building projects within <h1> ,<h1>Improve your front-end skills by building projects</h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

There is no need to give . wrapper a width. To center .container on the page using flexbox, replace the height in .wrapper with min-height: 100vh.

For a responsive content, replace the width in .container with max-width and give the img a max-width of 100%.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

P
Adrian 170

@litewskidev

Posted

@Hassiai Got it! Thanks for the advice. I really appreciate that. I'll take a special look at relative units for sure.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord