Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="wrapper"> with the main tag and wrap
Improve your front-end skills by building projects
within <h1> ,<h1>Improve your front-end skills by building projects</h1>
to fix the accessibility issue. click here for more on web-accessibility and semantic htmlThere is no need to give . wrapper a width. To center .container on the page using flexbox, replace the height in .wrapper with min-height: 100vh.
For a responsive content, replace the width in .container with
max-width
and give the img a max-width of 100%.Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@litewskidevPosted over 1 year ago@Hassiai Got it! Thanks for the advice. I really appreciate that. I'll take a special look at relative units for sure.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord