QR Code component solution

Community feedback

• 

  P

  Kent O'Sullivan•1,870

  @12KentosPosted over 2 years ago

  @Tommaso6468 You can use either classes or id's however classes are generally favored more, as they can be applied to multiple elements while an id can only be applied to one element. Another thing to keep in mind is that id's have a higher specificity than classes.

  Here are some good explanations of when to use a class or id.

  stack overflow

  develop intelligence

  Hope that helps!

  Marked as helpful

  1

  ---

  

  Tommaso van Gelderen•20

  @Tommaso6468Posted over 2 years ago

  @12Kentos Thank you!

  0
• 

  Hana•960

  @Hanka8Posted over 2 years ago

  Hi Tomasso, nice job!

  The main difference between ids and classes is that id can be used only on one element, while classes can be use for one ore more elements. The second thing is that ids are more specific, so they take precedence in your css. Generally classes are more common, because you can reuse them on other elements in greater projects.

  Other suggestions:

  • you should prefer semantic elements against non-semantic, so use <main> instead of <div>;

  • the document should have at least one <h1> landmark, so use <h1> on the heading instead of <p>;

  • the shadow around the card appears to be a little bit lighter than your solution, also the heading has a greater "font-weight"

  Keep up the good work!

  0