QR code component solution

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @IsuruAkalanka, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Isuru Akalanka Cumaranathunga•10

  @IsuruAkalankaPosted about 2 years ago

  @correlucas I am glad to here these suggestions to improve the design and code. thank you so much. This was very helpful. I am new to this platform and totaly satisfied with the community support in this. Again thanks so much.

  0
• 

  Funsho Ayobanjo•150

  @ayobanjoPosted about 2 years ago

  Hi @IsuruAkalanka, Good job on this. Just a few corrections to make it more responsive. Mark as helpful if you like it

  HTML

  Make the div a main for a more semantic structure.

  CSS

  1. On the div change the width to max-width: 300px for responsiveness

  2. Set the img element to max-width: 100% to always keep it within its container

  Marked as helpful

  1

  ---

  

  Isuru Akalanka Cumaranathunga•10

  @IsuruAkalankaPosted about 2 years ago

  Hi ayobanjo, thank you so much for your recommedations. I will do those corrections. I am new to CSS so these tips are very much helpful for me. Again thanks so much.

  0