@Blackpachamame
Posted
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="attribution">
to a<footer class="attribution">
š Some suggestions
- Use
min-height
andmax-width
, this will help the content stretch or shrink if you need to. Unlikeheight
andwidth
which can cause your content to be cut off on certain screens - Do not use
%
forwidth
orheight
. Better userem
,em
orpx
- You can apply
display: block
to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements - You can apply
margin
andpadding
in yourmain-container
, thediv
withcontainer
class is not necessary
Marked as helpful
@leamsi-ciber
Posted
Thanks Marcos, I appreciate your feedback.
I will take your recommendations to build better html and css code šš½