Skip to content
Submitted almost 3 years ago

QR code component solution

Maciej•280
@dreamspice
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Maciej•280
    @dreamspicePosted almost 3 years ago

    Hi, thank you for reply and advices :)

    I forgot to use semantic tags. Yeah, 'main' is probably the best for this case.

    I use 'h2' because i dont' want to change font-size but now i know it's bad practice.

    I will upgrade that and add media queries for 1440px width.

    All the best.

    1
  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    Hey good job on this challenge! Your report above shows a few issues. You can fix them by

    • wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Read more here
    • have at least one <h1> in your code

    Hope this helps :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord