QR Code Component

Hi Avinash Dhauni,

Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

• You should use <footer> for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

• In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.

• Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

Hopefully this feedback helps

Hi @avinashdhauni, how are you?

Congratulations on the challenge you did a great job on this challenge.

Despite this being an easy challenge, I had a lot of trouble doing it hahahahahh I was really happy when I finished it.

I have some tips for you:

If you want to define a rule for all code elements you can use:

* { margin: 0;}

Instead of putting it on the body!

The rest is really good!

Hope it helps... 👍