Design comparison
Solution retrospective
To design this you just need a basic knowledge of HTML and CSS. Pretty easy for beginners.
Community feedback
- @PhoenixDev22Posted about 2 years ago
Hi Avinash Dhauni,
Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- You should use
<footer>
for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor
not describes the image.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site usingtarget=”_blank”
attribute , you can expose your site to performance and security issues.
Hopefully this feedback helps
0 - You should use
- @AdrianoEscarabotePosted about 2 years ago
Hi @avinashdhauni, how are you?
Congratulations on the challenge you did a great job on this challenge.
Despite this being an easy challenge, I had a lot of trouble doing it hahahahahh I was really happy when I finished it.
I have some tips for you:
If you want to define a rule for all code elements you can use:
* { margin: 0;}
Instead of putting it on the body!
The rest is really good!
Hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord