QR Code Component (SCSS)

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @markrajk 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container">.

  • Additionally, you can use the <article> tag instead of div to the container card: <div class="card">.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).

  • The <h1> element is the main heading on a web page, there should only be one <h1> tag per page. You can create a <h1> and give it a suitable text:

  <h1 class="sr-only">QR Card Component</h1>
  

  The sr-only class is a class that you can add to hide content visually but is only visible to screen-readers.

  More information here.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1