QR Code Component ( HTML, SCSS)

Community feedback

• 

  Grego•1,310

  @Grego14Posted 7 months ago

  Hello! 🎉 congratulations on completing the challenge! 🎉

  I don't recommend that you use the br element to make the text break, if you are going to make styles use CSS, you can add a max-width to the text.

  example of use in the title:

  h1{
    max-width: 350px;
  }
  

  Now in the directories and files of the repository you should not use the docs directory to save your files, you can use the src directory.

  And that's it, the rest of the code looks good!

  I hope this helps! 😁

  Marked as helpful

  0

  ---

  

  Redened•40

  @RedenedPosted 7 months ago

  @Grego14 Thank you for the advice.

  I did not think of using width to make the text appear a certain way, that was very helpful.

  As for the directory, i thought the folder must be named docs in order to be accepted properly by the github pages settings. Could you elaborate a bit on that ?

  Also, i hope you don't mind me asking, i checked out your github profile and saw that you have the files for all your projects in a single repository and live pages for all of them as well. how did you accomplish that ? i thought you could only have 1 project along with 1 live site on an individual repository.

  0

  

  Grego•1,310

  @Grego14Posted 7 months ago

  @Redened When you create a github page they give you a url something like this:

  https://grego14.github.io/my_projects

  If in that 'my_projects' directory you have an index.html file, this will be the one used when you enter that url, but when you have multiple folders with multiple .html files you can specify them and those projects will be opened and not the one in the directory main, example:

  https://grego14.github.io/my_projects/project_1/

  https://grego14.github.io/my_projects/project_2/

  And so on. If it does not find a .html file it will use the readme.md.

  Now, with /docs, they give you two options to choose /docs or / which would be root, so it is not really necessary to use /docs for it to work, I recommend using /

  If you need anything else don't hesitate to ask!

  Marked as helpful

  0

  

  Redened•40

  @RedenedPosted 7 months ago

  @Grego14 Thank you for the information. You have been very helpful and i appreciate it deeply as i was not expecting much in terms of feedback when i joined this website.

  I will integrate your advice on github once im done with the tutorial solutions as i dont want to redo the repositories and whatnot.

  I've also followed you on here.

  Thank you again! ^^

  1