QR code component

Community feedback

• 

  22Theresecodes•80

  @22TheresecodesPosted over 1 year ago

  Hello there 👋. Congratulation for completing the challenge👍!

  I have some suggestions that will make your code better.

  CSS 🎨:

  Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can research more about it.

  I hope you find it useful! 😄 Above all, you did a good job!

  Marked as helpful

  1

  ---

  

  Godstime•330

  @iceberg61Posted over 1 year ago

  @22Theresecodes WOW thanks alot for the fantastic suggestion This helps alot

  0
• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🏷️:

  To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

  • Use ARIA landmarks such as <header role="banner"> and <footer role="contentinfo"> to provide additional information about the purpose of each section to assistive technologies.

  Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  0

  ---

  

  Godstime•330

  @iceberg61Posted over 1 year ago

  @Finney06 Thanks very much for your assesment

  0