Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Godstimeโ€ข 330

@iceberg61

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


well nothing was hard during the project. it was fun making it

Community feedback

22Theresecodesโ€ข 80

@22Theresecodes

Posted

Hello there ๐Ÿ‘‹. Congratulation for completing the challenge๐Ÿ‘!

I have some suggestions that will make your code better.

CSS ๐ŸŽจ:

Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can research more about it.

I hope you find it useful! ๐Ÿ˜„ Above all, you did a good job!

Marked as helpful

1

Godstimeโ€ข 330

@iceberg61

Posted

@22Theresecodes WOW thanks alot for the fantastic suggestion This helps alot

0
Finneyโ€ข 3,030

@Finney06

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

Here are some suggestions regarding your code that may be of interest to you.

HTML ๐Ÿท๏ธ:

To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

  • Use ARIA landmarks such as <header role="banner"> and <footer role="contentinfo"> to provide additional information about the purpose of each section to assistive technologies.

Here is a web accessibility evaluation tool๐Ÿ“• to check your webpage for any remaining errors or warnings related to landmarks.

I hope you find it helpful!๐Ÿ˜ Above all, the solution you submitted is ๐Ÿ‘Œ. ๐ŸŽ‰Happy coding!

0

Godstimeโ€ข 330

@iceberg61

Posted

@Finney06 Thanks very much for your assesment

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord