QR code component - SASS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  Nice work indeed, well done. One thing that i can point out is using the fixed px values which cannot be overwritten by users who want to pump up their font sizes. Using rems is encouraged. For a better explanation see why designers should move from px to rems

  1

  ---

  

  Oussama Zouaine•250

  @OussamaZouainePosted almost 3 years ago

  @ChamuMutezva thank you for the advice, Usually, I use rems and ems just for this challenge I thought using px is enough because the component looks the same for all screens.

  0
• 

  Diegochits•105

  @mrdiegodevPosted almost 3 years ago

  Good Work!

  1

  ---

  

  Oussama Zouaine•250

  @OussamaZouainePosted almost 3 years ago

  @mrdiegodev thank you :)

  0