QR Code Component - Samuel Santa

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  Hi, Samuel Santa! 👋

  For the project structure, I recommend keeping it simple. You don't need a src/ folder. You should use src/ folder when you are using a bundler such as Parcel.

  Put the HTML code for the site in the root folder. Don't put it inside another html/ folder. For the CSS, I recommend putting it in the root folder too.

  If you have more than one CSS file, let's say the minified for the production and the formatted code for the code review, then I recommend having a css/ folder in the root.

  The same goes for other types of file such as images and scripts.

  But, what I am saying here is just a guide. It is not an absolute rule to follow. The point is to keep your project structure as simple as possible.

  You can see my repository of this project as an example, vanzasetia/qr-code-component: A simple challenge by Frontend Mentor that boosts my motivation.

  For the code feedback, you should remove the srcset attribute from the <img>. It is empty.

  I hope this helps. Happy coding! 😄

  Marked as helpful

  0
• 

  Sumanth Chandana•720

  @sumanth-chandanaPosted over 1 year ago

  **Hi mate! congrats on completing the challenge. I have a suggestion for you:

  • The role attribute on an HTML element specifies the semantic meaning or purpose of the element for accessibility purposes. However, the value "card" is not a valid option for the role attribute. The role attribute has a predefined set of values that describe the roles of different elements, and "card" is not one of them.

  I hope this resolves your error.

  Marked as helpful

  0
• 

  Anei•30

  @aneimalienyPosted over 1 year ago

  Nice code mate, I would just say make the HTML more semantic in a way that screen readers would easily understand and interpret the HTML. Margin below the text might be too big, reduce it abit too.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Abraham•270

  @AbeeujahPosted over 1 year ago

  Hello, you submitted a nice solution and Here's some helpful tips to help you improve it

  HTML :

  Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  0