QR Code component

Community feedback

• 

  khushboo khatwani•1,070

  @khushi0909Posted over 1 year ago

  1. too big card as per requirement it should be little small and i think thats creating lot of vertical scroll bar

  2)you should learn about semantics HTML and using it for ex footer ,main etc

  3)for centering try to use flexbox or transform:translate() property ,I cant see both in your code ,learn flexbox and grid .

  4)instead of using fixed width ,should use max-width for the body or min-height 100vh etc ..

  All the best :)

  Marked as helpful

  0

  ---

  

  Ismae1•20

  @Ismae1Posted over 1 year ago

  @khushi0909

  Thank you for the great info, I'm going to try and implement flexbox or transform

  1
• 

  Felice Nicolas Barcellona•490

  @feliceNicolasBarcellonaPosted over 1 year ago

  if you'd like to take a look here https://www.frontendmentor.io/solutions/qrcodecomponentmain-p47hHnKHUD

  0

  ---

  

  Ismae1•20

  @Ismae1Posted over 1 year ago

  @feliceNicolasBarcellona

  Thank you Felice, I'm looking at the code to see how can Improve mine.

  0