Submitted over 1 year ago

QR Code component

Ismae1• 20

@Ismae1

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

This is my second challenge. Any feedback on my code would be great. I was trying to get my card to stay center when lower than 375px

Community feedback

khushboo khatwani• 1,070

@khushi0909

Posted over 1 year ago

too big card as per requirement it should be little small and i think thats creating lot of vertical scroll bar

2)you should learn about semantics HTML and using it for ex footer ,main etc

3)for centering try to use flexbox or transform:translate() property ,I cant see both in your code ,learn flexbox and grid .

4)instead of using fixed width ,should use max-width for the body or min-height 100vh etc ..

All the best :)

Marked as helpful

Ismae1• 20

@Ismae1

Posted over 1 year ago

@khushi0909

Thank you for the great info, I'm going to try and implement flexbox or transform

Felice Nicolas Barcellona• 480

@feliceNicolasBarcellona

Posted over 1 year ago

if you'd like to take a look here https://www.frontendmentor.io/solutions/qrcodecomponentmain-p47hHnKHUD

Ismae1• 20

@Ismae1

Posted over 1 year ago

@feliceNicolasBarcellona

Thank you Felice, I'm looking at the code to see how can Improve mine.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord