QR-code-component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 4 months ago

  Hi, congratulations on finishing this challenge!

  I have looked at your code, and here are my suggestions - I hope it is helpful :)

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>. I would also give the <div> a class, for clarity:<div class="card">.

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • As the card heading would likely not be the main heading on a page, I would change it to a <h2>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • We usually set the primary font on the body, so I would move font-family from the card to body.

  • I would remove the margin on the card, and instead use Flexbox on the body to center the card:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  

  • Remove all widths and heights in px. We rarely want to set fixed sizes - instead, our components should grow and shrink according to the screen size.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also never be in px. You can use em, where 1em equals the font size of the element.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it. I would also remove padding-bottom on the paragraph.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Remove margin-top.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card:padding: 16px;.

  0
• 

  Carmen•80

  @KrmenDevPosted 4 months ago

  I think It looks great, you achieve the result almost identical to the design

  0