Design comparison
Solution retrospective
Hello! This is my solution for QR code component. I have achieved 100% in Lighthouse score for performance, best practices, accessibility and SEO. 📊 Any tips are welcomed! Thank you. 😊✌️
Community feedback
- @danielmrz-devPosted 11 months ago
Hello, Alexandra 😊
Well done on this project!
I just have one tip for you to improve it:
- I noticed that the Outfit
font-family
was not working on your project even though you added it to your variables. I checked again and now I understad what happened:
This is your code:
--ff: font-family: "Outfit", sans-serif;
You accidentally added the words font-family: to your variable. You can fix it just by removing it from there, like this:
--ff: "Outfit", sans-serif;
Do that and your
font-family
will work 😊I hope it helps!
Other than that, great job!
Marked as helpful1 - I noticed that the Outfit
- @MohamedatePosted 11 months ago
Good job Alexandra But I have some point that imporve your challenge: 1- add font family to your challenge 2- add padding to bottom section in the card that make it amazing 2 - add margin between element to make good ui
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord