@DylandeBruijn
Posted
@lioba-s
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution π
- Responsive
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve βοΈ
-
You can remove
flex: initial;
andposition: relative;
on yourbody
element. I think you left these while experimenting. As far as I can see they don't make a difference while trying to achieve your result. -
Try to get into the habit of using classes more instead of ID's for styling your elements.
-
Try experimenting more with Flexbox, the
gap
property is very useful for example.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@lioba-s
Posted
@DylandeBruijn
Hi Dylan, thanks so much for taking the time and providing such helpful feedback. It was nice and easy to implement. I think I'll get back to this project in a while when I've gained more experience that will help me make improvements to it. π€
Oh, and the position: relative
on the body
(which I removed and then remembered π
) is there to keep the footer in place... (as described in this article: https://www.freecodecamp.org/news/how-to-keep-your-footer-where-it-belongs-59c6aa05c59c/ - feel free to tell me if you think a different approach would be more suitable here.
I just had a look at your version of this project and it's impressive how closely it resembles the original. β¨ All the best to you! π