QR Code Component | Beginner coding

Community feedback

• 

  Vitiyah Manimaran•180

  @VitiyahPosted almost 2 years ago

  Hi Putra,

  Follow the DRY method, Don't Repeat Yourself to make the code much shorter, for example

  .content h3, .content p { text-align: center; }

  This will make the code much shorter. Otherwise, good coding and great start. Wish you all the best

  Marked as helpful

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="card"> with the main tag and <h3> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Give .content a padding value for all the sides and give h1 a margin-bottom value or p a margin top value for the space between the text. Add a font-size of 15px/0.9375rem to .content this will reduce the font-size of h1 and p.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1