QR code component responsive

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi @AlexWesleyy,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  1. You should use <main> landmark for the card and <footer> for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  2. In my opinion,the alternate text in needed on this image. The alternate text should indicate where the Qr code navigate the user : like Qr code to frontend mentor.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  There are a lot the arguments against the 62.5% font size trick ,it state that you should never change the root font size because it harms accessibility.

  Aside these , Excellent work! hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Alex Wesley•70

  @AlexWesleyyPosted over 2 years ago

  @PhoenixDev22 Got it, thanks for the tips.

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @AlexWesleyy Happy coding!

  Marked as helpful

  0