QR-code-component (responsive)

Community feedback

• 

  Mahmoud-AbdelKarim•600

  @Mahmoud-Abdelkarim777Posted 4 months ago

  I saw your coding, thanks for your effort but you should learn how to center the element in the middle of the screen using grid or flexbox. You should remove the very large margin from here .c { height: 470px; width: 300px; background-color: white; /* margin: 180px auto 0 auto; */ border-radius: 15px; } Here is a solution to your problem: body{ display: flex justifay-content: center align-items: center min-height: 100vh }

  1
• 

  Marzia Jalili•4,630

  @MarziaJaliliPosted 4 months ago

  Bravo!!!!

  Some tips for a cleaner CSS:

  • use this lines of code in the body selector to centerize the container instead of this line margin: 140px auto 0 auto;:

  display: grid;
  place-items: center;
  min-height: 100vh;
  

  • avoid using a fixed height for the card. It isn't considered a good practice and there's no need for it when you have the lines above in the body.

  You can check out my solution for this challeng it is pretty straight forward, YOU WILL DEFINITELY BENEIFIT FROM IT!!!

  Hope it was helpful😁😁

  1

  ---

  

  volti42•50

  @volti42Posted 4 months ago

  @MarziaJalili Thank you my brother :)! I will review my project again considering what you've written. :) Greetings from Turkey <3 see u.

  0