Skip to content
Submitted over 1 year ago

QR Code Component - ReactJS and CSS

Nikhil Tanwar•260
@NikNT
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey everyone,

It was a simple project and I did not face any potential difficulty in executing this. I am trying to gradually upscale the difficulty level and ultimately reach GURU.

Please let me know how I did.

Thanks!

Community feedback

  • Chamu•13,130
    @ChamuMutezvaPosted over 1 year ago

    Hi Nikhil

    Here are some observations from my end.

    • the site is missing some landmark elements , I would expect to see the main element in this project and maybe the footer element since you have a div with the class footer
    • a site should have a heading element
    • font-sizes should not be in px values. This is better explained in the following article Why font-size must NEVER be in pixels
    Marked as helpful
    1
    Nikhil Tanwar•260
    @NikNTPosted over 1 year ago

    Hi @ChamuMutezva 👋🏽

    I really appreciate your feedback and I will surely take care of these things while coding my next project.

    Thank you for bringing out the mistakes. This would really help, someone like me, to improve a lot.

    Thanks ✌🏽

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord