Skip to content
Submitted about 2 years ago

QR Code Component Responsive

Daniel Montero•50
@danielomontero
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

👋🏽 Hi,

👨🏽‍🎨This is my first challenge 🚀 It's completed but I will to improve it with a new features

👨🏻‍🔧 Your feedback are welcome

Community feedback

  • PhoenixDev22•16,950
    @PhoenixDev22Posted about 2 years ago

    Hi Daniel Montero,

    Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

    • In my opinion, the alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor.

    hopefully this feedback helps.

    Marked as helpful
    1
    Daniel Montero•50
    @danielomonteroPosted about 2 years ago

    @PhoenixDev22 I have solved what you have told me, but the new report does not change, any idea of what could be happening?

    0
    PhoenixDev22•16,950
    @PhoenixDev22Posted about 2 years ago

    @danielomontero After you update your code in the GitHub repository, you can generate another report for your solution . Happy coding!

    0
    Daniel Montero•50
    @danielomonteroPosted about 2 years ago

    @PhoenixDev22 That's what I did, however, the report still shows two warnings

    0
  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    Fala Daniel, beleza? Parabéns pelo desafio.

    Acabei de ver sua solução e o erro no report é vou te passar a estrutura de HTML com. O código limpo é tirando o erro. Pode apagar o role que vc adicionou no main e segue os passos, o código vai ficar limpo quando vxbsegurar todo conteúdo em um bloco só usando (<main> ou <div>) nesse caso vamos usar <main> por que é uma tag semantica. Se você notar, nem precisa adicionar nenhum div além da principal pra segurar o conteúdo (img, h1 e p). A estrutura ideal e mais limpa possível pra esse desafio é essa aqui:

    <body>
<main>
<img>
<h1></h1>
<p></p>
</main>
</body>

    Vê aí se soluciona seu problema e dps me fala

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord