QR code component

Community feedback

• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi @D4R0M, how are you?

  You did a great job on this challenge, but I have a few tips I think you'll like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  I noticed that you centered the content using position: absolute;, always prefer to use grid or flex-box, for example:

  I removed the commented code:

  .contianer { /* margin: 0 auto; */ /* position: absolute; */ /* top: 50%; */ /* left: 50%; */ /* transform: translate(-50%, -50%); */ }

  I added these:

  body { display: flex; align-items: center; justify-content: center; min height: 100vh; }

  To make the code cleaner you could have just done:

  main img h1 p

  The rest is great! Hope it helps... 👍

  Marked as helpful

  1