QR code component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello there, Kalim! 👋

  Congratulations on finishing this challenge! 🎉

  Alternative text for any images should not have any words that are related to "image". So, my recommendation is to remove the word image. Also, the alternative text can be improved by telling the user what the QR code is for. I suggest improving the alternative text to "QR code for frontendmentor.io". This way, the user knows that it is a QR code image for the Frontend Mentor site.

  Even though it's not a big deal on a small project like this one, however, it is important to write low specificity stylesheet from now. In your CSS, I noticed this selector section .text p:first-child which would be much be as .text p:first-child. This still can be improved by adding a class name to it so you can just directly select the element by referencing it using its class name. This way, when working on a larger project the stylesheet is more maintainable and easier to understand if you want to refactor it in the future.

  That's it! Hope this helps. 😊

  Marked as helpful

  2

  ---

  

  Kalim•70

  @Kalim22Posted over 2 years ago

  @vanzasetia Thank you 😊😊

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Kalim22 You're welcome! 👍

  0