Design comparison
Solution retrospective
I'm always happy for some feedback.
Community feedback
- @amalkarimPosted almost 2 years ago
Hi Phuong,
Congratulations for completing the challenge!
It's an interesting solution, and a great one too! It has a nice structure, and you're using
<section>
which is semantic in my opinion. If you want to go further and make the page more accessible, I will suggest you to check out the Accessibility report and HTML validation report tabs in this page. They will give you suggestions to improve your page. For example, we could add<main></main>
element and wrap everything inside it. We could also add another landmark:<footer></footer>
and place the attribution code inside it.Hope this helps. Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord