Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100vhforbodyinstead ofmin-height: 216px. Setting themin-height: 216pxmay result in the component being cut off on smaller screens.
- So we want set
min-height: 100vhthen thebodywill start at100vh, if the content pushes thebodybeyond100vhit will continue growing. However if you have content that takes less than100vhit will still take100vhin space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1
P
Piwko Marcin• 180
@PiwkoO
Posted
Hi @0xAbdulKhalid 👋
Thank you so much for your feedback. I'm happy that you took the time to overview my solution 😄
I have one question because min-height in the body is set automatically by JavaSctipt. At first, I used 100vh but it didn't look good on mobile devices because of the browser toolbar.
Am I missing something? Could you show me how it looks on your side so I could fix it if there's any problem with the code?
0
