Skip to content
Submitted over 1 year ago

QR Code Component

Batuhan Orhan•40
@bthnorhan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I will greatly appreciate any advice/feedbacks.

Community feedback

  • Stanley Nadar•370
    @istealersn-devPosted over 1 year ago

    Great efforts! Congratulations on completion of the challenge

    When you build HTML, its important that you get the semantics right as that boosts accessibility and SEO. In your HTML structure you are missing <main> tag inside body specifying that its the main content of the body and including at least one <h1> is mandate as per web standards. You should avoid using <h6> without having a proper logical sequence such as <h1>..<h2>..<h3>..<h4>..<h5>..<h6>; its highly important from web and accessibility standards perspective that you do not skip the sequence while structuring your content.

    On the tailwind front:

    • You can avoid the p-6 for <body> as it has no role to play and as a practice avoid setting padding to entire body instead can do so on sections/div.
    • Similarly id="card" can also be avoided therefore makes it redundant.
    • Always assign descriptive alt text, such as alt="Frontendmentor.io website QR code"

    Hope this is helpful!

    Marked as helpful
    1
    Batuhan Orhan•40
    @bthnorhanPosted over 1 year ago

    @istealersn-dev thanks a lot!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord