Skip to content
Submitted over 2 years ago

QR code component

Italo Régis•20
@italoregis
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Suraj Raju Hadage•670
    @SurajHadagePosted over 2 years ago
    • Use <main> tag for your design because this is main content of your webpage and not a section.
    • Always use <h1> tag for every webpage and I can see in your code.
    • To shorten your HTML you can do :
      <main>
    <figure><img></figure>
    <h1></h1>
    <p></p>
  </main>
    • You can center this with position absolute or display flex method.
    • Make sure to give padding to parent element (main) instead setting margins to every child element.
    • Use Paint app to know dimensions of your design.
    • You are using max-width: 1440px to <body>. Your <main> element will not be in center when width exceeds 1440px.
    • I would suggest to not upload unnecessary files and folders to save server space.
    • Give some @media query for smaller devices like galaxy fold.
    0
    Italo Régis•20
    @italoregisPosted over 2 years ago

    @SurajHadage Thanks. I uploaded some updates but is still miss something. =/

    0
    Suraj Raju Hadage•670
    @SurajHadagePosted over 2 years ago

    @italoregis

    I suggest you to use Paint app to get accurate dimensions. Take a look at my solution on my profile.

    0
    Italo Régis•20
    @italoregisPosted about 2 years ago

    @SurajHadage Thanks, Suraj. I will make sure to use paint from now on. Appreciate the tip.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord