QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  CSS 🎨:

  • If the sole purpose is just to group the text elements together, then using an additional div is unnecessary, as it would only add an extra tag without a clear functional purpose. However, if you plan to apply styles or other properties to both the h2 and p elements collectively, then wrapping them in a div is a valid approach to ensure consistent styling and structure.

  • Avoid using position: absolute to center an element as it may result in overflow on some screen sizes. screenshot-imgur (landscape mode)📸

    Instead, utilize the flexbox or grid layout for centering. Get more insights on centering in CSS here here 📘.

  • You should use the box-sizing: border-box property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1