Design comparison
Solution retrospective
Of course I am open to read all the feedback you want to share with me.
Thank you in advance.
Community feedback
- @HassiaiPosted over 1 year ago
To center .main__container on the page using flexbox, replace the height in the main with min-height: 100vh.
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
For a responsive content which wont require a media query for this challenge,
- Reduce the max-width value and the padding value of .main__container
max-width: 320px which is 20rem/em padding:16px which is 1rem/em
- Give the img a max-width of 100% and a border-radius value, the rest are not needed.
Give .main_container-text a margin value for all the sides and text-align: center. Give p a margin-top or h1 a margin-bottom value for the space between the text.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1@CristianArielDelgadoPosted over 1 year agoHi @Hassiai, thank you so much for your feedback. I really appreciate it so much.
0 - Reduce the max-width value and the padding value of .main__container
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord