Skip to content
Submitted 8 months ago

QR code component

Jeff Gicharu•80
@jeffgicharu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm mainly proud of the fact that I was able to finish this challenge despite being very confused when I started.

What challenges did you encounter, and how did you overcome them?

As I was adding styles in the CSS, there was a element which was not behaving as expected when I tried to style it. I overcame the challenge by trying different possible solutions until I found one that worked.

What specific areas of your project would you like help with?

I would like help in knowing when to add classes to HTML elements and also in the organization of my CSS.

Community feedback

  • Rowan•230
    @rowanDeveloperPosted 8 months ago

    Hi @jeffgicharu,

    Congrats on submitting your first solution! Keep it up! FrontEnd Mentor is a great place to practice and improve your coding skills.

    I took a look at your code and I like the fact that it is pretty clean and concise. I would add some changes, like, for example, using the <main> tag instead of <article> or <section>. The idea is that the <main> tag holds everything. I would also have a div container, just so I could better manipulate the padding and another div for the image-container to better adjust the width and height of the image. But that is just my logic of programming.

    Something like:

             body 
             <main>
	            <div class="container">
		            <div class="image-container">
			         <img href="./">
		           </div>
		           code 
		
	             </div>
           </main>

    Overall, congrats on your first project!

    Marked as helpful
    0
    Jeff Gicharu•80
    @jeffgicharuPosted 8 months ago

    Hello @rowanDeveloper Thank you very much for your feedback. I started learning HTML and CSS recently and the teacher that I'm following on YouTube suggests avoiding using divs too much and instead insists on using specific HTML tags so that the code can have more meaning.

    1
  • mbalali63•150
    @mbalali63Posted 8 months ago

    Hi @jeffgicharu Thank you for the great work. The html and css file are well structured and excellent. I just think that your font sizes are too small. it may be good enough if it will be increased from 15px to 19px for the header text and the other 17px. And also please consider the background color which is different from the design. Hope this is helpful for your great work.

    0
    Jeff Gicharu•80
    @jeffgicharuPosted 8 months ago

    Hi @mbalali63 Thank you for pointing that out. I also noticed that the font sizes were too small but since I'm a beginner, I was trying to follow exactly what they wrote in the style markdown file about the sizes.

    0
  • Charlie•300
    @XarlizardPosted 8 months ago

    Heyo,

    I think that you've swapped body background-color with .para:last-child text color , other than that, really good man keep it up! 😉👍

    0
    Jeff Gicharu•80
    @jeffgicharuPosted 8 months ago

    Hey @Xarlizard Thank you for that correction. I had not even noticed it. But I've made the correction so I think now it is okay.

    1
    Charlie•300
    @XarlizardPosted 8 months ago

    @jeffgicharu yeah it is, it looks amazing now well done 😊

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord