Skip to content
Submitted almost 2 years ago

QR code component

Kimball S Sumney•120
@ks5ks
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Fun challenge, gained a better understanding of margin and padding. I didn't use any <div> elements since they didn't seem needed, is this a good thing? Of course any other feedback is welcome. Thanks, Kimball

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    HTML 📄:

    • Wrap the page's whole main content in the <main> tag.
    • There is no HTML5 element called <container>. The most common element to use for a container is <div>

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    1
    Kimball S Sumney•120
    @ks5ksPosted almost 2 years ago

    @MelvinAguilar Thanks for your comments, I appreciate it.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord