Design comparison
Solution retrospective
Fun project. I was not sure if the mobile design was supposed to be a different set of code or if the one set of code was supposed to resize to look like the mobile version. Any tips and feedback are much appreciated.
Community feedback
- @0xabdulkhaliqPosted about 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute which should explain the purpose of theimage
.
- The
alt
withqr-code
is not even explaining for what the QR image need to be used.
- So update the
alt
with meaningful text which explains likeQR code to frontendmentor.io
- Example:
<img src="images/image-qr-code.png" alt="QR code to frontendmentor.io" class="qr-code-img">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@acoreyuPosted about 1 year agoThank you for the recommendation. That makes a lot of sense, I will definitely update the code to add that alt tag. @0xAbdulKhalid
0 - @Durga-JaiswalPosted about 1 year ago
Overall project was Good
In img tag
padding: 20px
should be10px
so that it matches with the given design.and there should be some padding in
header-text
andguide-text
classes.I hope it helps you.
Marked as helpful0@acoreyuPosted about 1 year ago@Durga-Jaiswal Thank you for the pointers. I will make some adjustments.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord