QR code component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with qr-code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example:

  <img src="images/image-qr-code.png" alt="QR code to frontendmentor.io" class="qr-code-img">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Corey•20

  @acoreyuPosted about 1 year ago

  Thank you for the recommendation. That makes a lot of sense, I will definitely update the code to add that alt tag. @0xAbdulKhalid

  0
• 

  Durga Jaiswal•230

  @Durga-JaiswalPosted about 1 year ago

  Overall project was Good

  In img tag padding: 20px should be 10px so that it matches with the given design.

  and there should be some padding in header-text and guide-text classes.

  I hope it helps you.

  Marked as helpful

  0

  ---

  

  Corey•20

  @acoreyuPosted about 1 year ago

  @Durga-Jaiswal Thank you for the pointers. I will make some adjustments.

  0