Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found

Submitted

QR Code Component

P

@gumrahsindar

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my first project on Frontend Mentor, and I will be so pleased if you tell me if there are mistakes or deficiencies.

Community feedback

@MelvinAguilar

Posted

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • Add a small margin to the component to prevent it from touching the edges of the screen on mobile devices.
  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

1

P

@gumrahsindar

Posted

These are very useful suggestions, thank you! @MelvinAguilar

0
Finney 3,030

@Finney06

Posted

Hello there 👋. Good job on completing the challenge !

Here are some suggestions regarding your code that may be of interest to you.

HTML 🏷️:

To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

1

P

@gumrahsindar

Posted

@Finney06 Thank you so much!! I've already noted down your suggestions. 😊

0
P
visualdennis 8,375

@visualdenniss

Posted

Great job in completing the challenge successfully! Your solution looks great overall, the design implementation is simple neat. Both mobile and desktop view respond well to resizing.

There is nothing much i can add, perhaps you can add a box-shadow to the card itself to enhance it even further. You can pick one from here: https://getcssscan.com/css-box-shadow-examples

If this was helpful, feel free to mark it as helpful! Good luck on upcoming projects!

1

P

@gumrahsindar

Posted

@visualdenniss Thank you so much 💙

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord