Design comparison
SolutionDesign
Solution retrospective
Easy work for starters.
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <h2. with <h1> to fix the accessibility issues for more on semantic html visit https://web.dev/learn/html/semantic-html/.
Give container height: 100vh instead of 80vh.
Since you gave .container a max-width , then there is no need for a media query.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord