@keyztrokee
Posted
Hi, Rico! Very cool solution, it really looks great :)
I noticed three things that you might want to consider:
- Change the h1 color to var(--clr-dark-blue) because it is not black.
2.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.
3.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.
Other than that, really great job! :)
โ๏ธ I hope this helps you and happy coding!
Marked as helpful
@correlucas
Posted
@keyztrokee Amazing tips Raymond!
@keyztrokee
Posted
@correlucas Hi, I just copied it from your suggestion to my work and I think it will help him too. Great help by the way, thank you very much!
@correlucas
Posted
@keyztrokee ok
@keyztrokee
Posted
@correlucas Can you give feedback on my last work too? I would love to see what I can do better with it. Please consider taking a look at it if you have time. Thank you very much!
@Shuliii
Posted
@keyztrokee thankyou so much for the feedback. much appreciated.